Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix UNNECESSARY_TYPE_CHECK_TRUE. #4284

Merged

Conversation

scheglov
Copy link
Contributor

To land https://dart-review.googlesource.com/c/sdk/+/190360 we need to fix pre-existing violations.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.
Since there's no behavioral changes in the non-test code. We can skip the version update.

@cyanglaz cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 27, 2021
@fluttergithubbot fluttergithubbot merged commit d9f90b5 into flutter:master Aug 27, 2021
@scheglov scheglov deleted the fix-UNNECESSARY_TYPE_CHECK_TRUE branch August 27, 2021 20:25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: in_app_purchase platform-android platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants