-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
|
||
- name: Linux ci_yaml plugins roller | ||
recipe: infra/ci_yaml | ||
bringup: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this affect the plugins tree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No as the plugins tree is computed from cirrus (see submit-queue). I'm enabling it bringup as otherwise this PR can't roll into infra to generate the try builder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
I manually re-ran one of the failing tasks and it passed, so it looks like there was transient infra outage unrelated to the PR.
bc543bc
to
04ba3cf
Compare
flutter/flutter#84998
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).