Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix crash from null Google Maps object #4250

Merged
merged 7 commits into from
Sep 15, 2021
Merged

Fix crash from null Google Maps object #4250

merged 7 commits into from
Sep 15, 2021

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Aug 19, 2021 •
edited
Loading

Prevent crash when PlatformView.dispose was called before OnMapReadyCallback.onMapReady. OnMapReadyCallback.onMapReady is responsible for setting the googleMap object.

Fixes flutter/flutter#87566

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Aug 19, 2021
@bparrishMines bparrishMines changed the title remove ignore [WIP] remove ignore Aug 19, 2021
@bparrishMines bparrishMines removed the request for review from cyanglaz August 19, 2021 17:21
@bparrishMines bparrishMines changed the title [WIP] remove ignore Fix crash from null Google Maps object Aug 19, 2021
stuartmorgan
stuartmorgan approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay.

stuartmorgan
stuartmorgan suggested changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, wait; this is changing non-test code, so we should bump the version. Especially as this is a bug that could presumably be happening in the wild.

stuartmorgan
stuartmorgan approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 14, 2021
@fluttergithubbot fluttergithubbot merged commit 41cb992 into flutter:master Sep 15, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 15, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 15, 2021
@engine-flutter-autoroll
41cb992 Fix crash from null Google Maps object (flutter/plugins#4250)
ea1bff0
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Sep 15, 2021
@engine-flutter-autoroll
41cb992 Fix crash from null Google Maps object (flutter/plugins#4250)…
269f2d8 
… (#90100)
@bparrishMines bparrishMines deleted the remove_maps_ignore branch September 15, 2021 18:19
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@bparrishMines @amantoux
Fix crash from null Google Maps object (flutter#4250)
d749cc4
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@bparrishMines @KyleFin
Fix crash from null Google Maps object (flutter#4250)
e3f4d10
@lukaskurz lukaskurz mentioned this pull request Jul 14, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blasten blasten blasten left review comments

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
cla: yes p: google_maps_flutter platform-android waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[google_maps_flutter] Android googleMapsPluginIsAdded failing on master
4 participants
@bparrishMines @stuartmorgan @blasten @fluttergithubbot