Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera_web] Add missing setFlashMode test #4235

Merged
merged 1 commit into from
Aug 12, 2021
Merged

[camera_web] Add missing setFlashMode test #4235

merged 1 commit into from
Aug 12, 2021

Conversation

bselwe
Copy link
Contributor

@bselwe bselwe commented Aug 12, 2021

Added missing CameraPlugin.setFlashMode test to verify if the method is called on the Camera with the given id.

Part of flutter/flutter#45297.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@bselwe bselwe requested a review from bparrishMines as a code owner August 12, 2021 10:16
@google-cla google-cla bot added the cla: yes label Aug 12, 2021
@bselwe
Copy link
Contributor Author

bselwe commented Aug 12, 2021

@ditman @felangel

@bselwe bselwe mentioned this pull request Aug 12, 2021
Open
ditman
ditman approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the test! (Did I mess this one up in my merges?)

@ditman ditman merged commit 1e497d6 into flutter:master Aug 12, 2021
@bselwe
Copy link
Contributor Author

bselwe commented Aug 13, 2021

@ditman I think I just forgot about this one. 😄

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2021
@engine-flutter-autoroll
1e497d6 [camera_web] Add missing setFlashMode test (flutter/plugins#4235
2411c6a 
)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@bselwe @fotiDim
[camera_web] Add missing setFlashMode test (flutter#4235)
b93dd31
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@bselwe @amantoux
[camera_web] Add missing setFlashMode test (flutter#4235)
d354655
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
cla: yes p: camera platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bselwe @ditman