Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera_web] Fix getCapabilities not supported error thrown when selecting a camera on Firefox #4234

Merged
merged 4 commits into from
Aug 12, 2021
Merged

[camera_web] Fix getCapabilities not supported error thrown when selecting a camera on Firefox #4234

merged 4 commits into from
Aug 12, 2021

Conversation

bselwe
Copy link
Contributor

@bselwe bselwe commented Aug 12, 2021

Fixed getCapabilities not supported error thrown when selecting a camera on Firefox.

Before, the method was always called and an exception was thrown on Firefox with its runtime type checked against JSNoSuchMethodError. This caused issues as the runtime type was different depending on the build mode (release, profile, staging). Now, the method is called only if it is available on the video track (checked with JsUtil.hasProperty).

Part of flutter/flutter#45297.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@bselwe
Copy link
Contributor Author

bselwe commented Aug 12, 2021

@ditman @felangel

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change for the better. RuntimeTypes in the web are rarely usable.

@ditman ditman merged commit e5fc83d into flutter:master Aug 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
…lecting a camera on Firefox (flutter#4234)

* feat: check if getCapabilities can be called rather than catching an exception
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
…lecting a camera on Firefox (flutter#4234)

* feat: check if getCapabilities can be called rather than catching an exception
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants