This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Fix pickImage not returning on iOS when dismissing the PHPicker view by swiping down. #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitadol
approved these changes
Aug 13, 2021
renefloor
suggested changes
Aug 17, 2021
packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m
Outdated
Show resolved
Hide resolved
renefloor
approved these changes
Aug 23, 2021
renefloor
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2021
…sing the PHPicker view by swiping down. (flutter/plugins#4228)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2021
…sing the PHPicker view by swiping down. (flutter/plugins#4228)
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 23, 2021
…sing the PHPicker view by swiping down. (flutter/plugins#4228) (#88699)
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
… PHPicker view by swiping down. (flutter#4228)
jolmiracle
pushed a commit
to miracle-as/webview_flutter
that referenced
this pull request
Sep 24, 2021
… PHPicker view by swiping down. (flutter#4228) # Conflicts: # packages/image_picker/image_picker/CHANGELOG.md # packages/image_picker/image_picker/pubspec.yaml
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
… PHPicker view by swiping down. (flutter#4228)
|
@BeMacized |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the PHPicker view is used for picking images on iOS, methods like
pickImagedo not return a value when dismissing the view by swiping down. It only sends a result when explicitly pressing the cancel action, or when any content is picked.This PR fixes this by also sending a result when the view is dismissed.
Relevant issue:
Pre-launch Checklist
dart format.)[shared_preferences]///).