This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[camera_web] Add support for device orientation #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
approved these changes
Aug 7, 2021
| if (orientation != null && documentElement != null) { | ||
| // Full-screen mode may be required to modify the device orientation. | ||
| // See: https://w3c.github.io/screen-orientation/#interaction-with-fullscreen-api | ||
| documentElement.requestFullscreen(); |
There was a problem hiding this comment.
If the orientation is locked, do we need to requestFullscreen? Wouldn't this already be in fullscreen?
There was a problem hiding this comment.
Good point, this can be skipped here. Will remove it.
| throw UnimplementedError( | ||
| 'onDeviceOrientationChanged() is not implemented.', | ||
| ); | ||
| final orientation = window?.screen?.orientation; |
There was a problem hiding this comment.
I'm surprised these are not breaking analysis, we used to require to specify types in these definitions.
ditman
added
the
waiting for tree to go green
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 13, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for device orientation to the web camera platform.
OrientationTyperepresenting a screen orientation type of the browser (ScreenOrientation.type).lockCaptureOrientationimplementation.ScreenOrientation.lock.PlatformExceptionwhen the screen orientation API is not supported.unlockCaptureOrientationimplementation.ScreenOrientation.unlock.PlatformExceptionwhen the screen orientation API is not supported.onDeviceOrientationChangedimplementation.ScreenOrientation.onchange.Part of flutter/flutter#45297.
Pre-launch Checklist
dart format.)[shared_preferences]///).