Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Don't use 'flutter upgrade' on Cirrus #4213

Merged
merged 4 commits into from
Aug 4, 2021

Conversation

stuartmorgan
Copy link
Contributor

This command isn't intended for CI use, and is also slower due to
downloading artifacts that will be immidately discarded.

Cirrus portion of flutter/flutter#86037

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

This command isn't intended for CI use, and is also slower due to
downloading artifacts that will be immidately discarded.

Cirrus portion of flutter/flutter#86037
@stuartmorgan stuartmorgan requested a review from jmagman August 2, 2021 18:02
@google-cla google-cla bot added the cla: yes label Aug 2, 2021
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christopherfujino This looks right to me, can you think of any more gotchas to resetting since you're been conductoring?

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only difference under the hood between these commands and doing flutter upgrade is that the latter will also precache certain artifacts. However, the tool should ensure any necessary cache artifacts in the validation phase of any command (e.g. ios artifacts before flutter build ios), so this should be fine.

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan merged commit 6010090 into flutter:master Aug 4, 2021
@stuartmorgan stuartmorgan deleted the no-upgrade branch August 4, 2021 13:45
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
This command isn't intended for CI use, and is also slower due to
downloading artifacts that will be immidately discarded.

Cirrus portion of flutter/flutter#86037
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
This command isn't intended for CI use, and is also slower due to
downloading artifacts that will be immidately discarded.

Cirrus portion of flutter/flutter#86037
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants