-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Don't use 'flutter upgrade' on Cirrus #4213
Conversation
This command isn't intended for CI use, and is also slower due to downloading artifacts that will be immidately discarded. Cirrus portion of flutter/flutter#86037
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christopherfujino This looks right to me, can you think of any more gotchas to resetting since you're been conductoring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The only difference under the hood between these commands and doing flutter upgrade
is that the latter will also precache certain artifacts. However, the tool should ensure any necessary cache artifacts in the validation phase of any command (e.g. ios artifacts before flutter build ios
), so this should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This command isn't intended for CI use, and is also slower due to downloading artifacts that will be immidately discarded. Cirrus portion of flutter/flutter#86037
This command isn't intended for CI use, and is also slower due to downloading artifacts that will be immidately discarded. Cirrus portion of flutter/flutter#86037
This command isn't intended for CI use, and is also slower due to
downloading artifacts that will be immidately discarded.
Cirrus portion of flutter/flutter#86037
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).