Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera_web] Add takePicture implementation #4196

Merged
merged 4 commits into from
Jul 27, 2021
Merged

[camera_web] Add takePicture implementation #4196

merged 4 commits into from
Jul 27, 2021

Conversation

bselwe
Copy link
Contributor

@bselwe bselwe commented Jul 27, 2021

Adds takePicture implementation of the camera platform interface.

  • Calls takePicture on the Camera with the given id.

Part of flutter/flutter#45297.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@bselwe bselwe requested a review from bparrishMines as a code owner July 27, 2021 10:43
@google-cla google-cla bot added the cla: yes label Jul 27, 2021
@bselwe
Copy link
Contributor Author

bselwe commented Jul 27, 2021

@ditman @felangel @orestesgaolin

@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: no and removed cla: yes labels Jul 27, 2021
@ditman

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 27, 2021
ditman
ditman approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The infrastructure work of earlier pushes is paying off now! Super easy to understand change!

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jul 27, 2021
felangel
felangel reviewed Jul 27, 2021
View reviewed changes
packages/camera/camera_web/example/integration_test/camera_web_test.dart
Comment on lines +505 to +506
when(camera.takePicture)
.thenAnswer((_) => Future.value(capturedPicture));
Copy link
Contributor

@felangel felangel Jul 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
when(camera.takePicture)
.thenAnswer((_) => Future.value(capturedPicture));
when(camera.takePicture).thenAnswer((_) async => capturedPicture);

nit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update in the next PRs, thanks!

felangel
felangel reviewed Jul 27, 2021
View reviewed changes
packages/camera/camera_web/lib/src/camera_web.dart
@@ -271,7 +271,7 @@ class CameraPlugin extends CameraPlatform {

@override
Future<XFile> takePicture(int cameraId) {
throw UnimplementedError('takePicture() is not implemented.');
return getCamera(cameraId).takePicture();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fluttergithubbot fluttergithubbot merged commit 9e23302 into flutter:master Jul 27, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021
@engine-flutter-autoroll
9e23302 [camera_web] Add takePicture implementation (flutter/plugin…
8ccc200 
…s#4196)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@bselwe @fotiDim
[camera_web] Add takePicture implementation (flutter#4196)
483ae9c
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@bselwe @amantoux
[camera_web] Add takePicture implementation (flutter#4196)
6bb6393
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felangel felangel felangel approved these changes

@ditman ditman ditman approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
cla: yes p: camera platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bselwe @ditman @felangel @fluttergithubbot