This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Move unit tests to Android modules #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
commented
Jul 26, 2021
| } | ||
|
|
||
| @Test | ||
| public void requestScopes_ResultErrorIfAccountIsNull() { |
There was a problem hiding this comment.
These tests were copied and pasted from the tests in example/android/app/src/test....
bparrishMines
changed the title
bparrishMines
commented
Jul 26, 2021
|
|
||
| @RunWith(RobolectricTestRunner.class) | ||
| @Config(sdk = Build.VERSION_CODES.P) |
There was a problem hiding this comment.
This was added due to an error that complained about missing sdk 20. I was only able to get it working after looking at https://stackoverflow.com/questions/56808485/robolectric-and-android-sdk-29/57261194#57261194. I'm assuming this could also be increased depending oon what version we want to run it on
stuartmorgan
approved these changes
Jul 26, 2021
blasten
approved these changes
Jul 26, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#82470
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.