Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add buildViewWithTextDirection to platform interface #4121

Merged
merged 8 commits into from
Aug 9, 2021
Merged

Add buildViewWithTextDirection to platform interface #4121

merged 8 commits into from
Aug 9, 2021

Conversation

bparrishMines
Copy link
Contributor

Adds buildViewWithTextDirection to the platform interface. Originally, this was only a method in the MethodChannel implementation.

Tests for this can only be added google_maps_flutter once this is published. Currently they're in #4082.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines requested a review from cyanglaz as a code owner June 30, 2021 20:38
@google-cla google-cla bot added the cla: yes label Jun 30, 2021
@bparrishMines bparrishMines mentioned this pull request Jun 30, 2021
Merged
11 tasks
stuartmorgan
stuartmorgan approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart Outdated Show resolved Hide resolved
...ps_flutter_platform_interface/lib/src/method_channel/method_channel_google_maps_flutter.dart Outdated Show resolved Hide resolved
...ps_flutter_platform_interface/lib/src/method_channel/method_channel_google_maps_flutter.dart Outdated Show resolved Hide resolved
@bparrishMines bparrishMines added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 9, 2021
@fluttergithubbot fluttergithubbot merged commit 19f2ff7 into flutter:master Aug 9, 2021
@bparrishMines bparrishMines deleted the maps_interface branch August 9, 2021 19:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2021
@engine-flutter-autoroll
19f2ff7 Add buildViewWithTextDirection to platform interface (flutt…
41aa7dd 
…er/plugins#4121)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@bparrishMines @fotiDim
Add buildViewWithTextDirection to platform interface (flutter#4121)
394abad
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@bparrishMines @amantoux
Add buildViewWithTextDirection to platform interface (flutter#4121)
eef7c0b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
cla: yes p: google_maps_flutter waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bparrishMines @stuartmorgan @fluttergithubbot