Remove podspec lint bash script, use flutter_plugin_tools

[jmagman]

Description

Remove lint podspec bash script, use flutter_plugin_tools podspecs command.

Related Issues

Command introduced with https://github.com/flutter/plugin_tools/pull/69.
Fixes flutter/flutter#41511

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
• All existing and new tests are passing.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the [Flutter Style Guide].
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
• I updated CHANGELOG.md to add a description of the change.
• I signed the [CLA].
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

• Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
• No, this is not a breaking change.

[mklim]

LGTM

[mklim]

nit: Would it be worth doing this before any of the other steps? That way if there's a lint error this will fail immediately instead of waiting until everything else completes.

[jmagman]

Or maybe I should split it into its own shard so if one fails you still get the output from the others?

[mklim]

That makes sense too. I think either is fine.

[jmagman]

I fixed the new prefer_single_quotes warnings, but I don't want to fix the omit_local_variable_types since I think that will go away once packages/google_sign_in/google_sign_in//analysis_options.yaml gets removed (see https://github.com/flutter/plugin_tools/pull/75)
https://cirrus-ci.com/task/5563407964569600?command=main#L50

[jmagman]

I fixed the new prefer_single_quotes warnings, but I don't want to fix the omit_local_variable_types since I think that will go away once packages/google_sign_in/google_sign_in//analysis_options.yaml gets removed (see flutter/plugin_tools#75)
https://cirrus-ci.com/task/5563407964569600?command=main#L50

Also I'm not sure know why they just now surfaced, those double quotes are from 2017.

[mklim]

@jmagman it's because I didn't lock the pedantic package and it silently upgraded to 1.9.0 underneath CI. I have an open PR right now to lock it back down to 1.8.0. #2354

[jmagman]

@jmagman it's because I didn't lock the pedantic package and it silently upgraded to 1.9.0 underneath CI. I have an open PR right now to lock it back down to 1.8.0. #2354

🤦‍♀ I forgot it too in plugin_tools https://github.com/flutter/plugin_tools/pull/76

[jmagman]

This has been good and truly borked by federated plugins, trying to wack-a-mole errors as they get merged.

[jmagman]

I can see the error now with https://github.com/flutter/plugin_tools/pull/84!

 -> google_sign_in (0.0.1)
    - WARN  | license: Missing license type.
    - WARN  | [iOS] keys: Missing primary key for `source` attribute. The acceptable ones are: `git, hg, http, svn`.
    - ERROR | [iOS] unknown: Encountered an unknown error (/bin/bash -c 
set -e
unzip Flutter.framework -d Flutter.framework
Archive:  Flutter.framework.zip
Archive:  Flutter.framework.ZIP
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
) during validation.

The Flutter.framework.zip is corrupted?