Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@rakeshlanjewar
Copy link

can fix #25351,#26009,#26347,#27006

I have added a way from platform channels to enable redirect by using this method

         webView.setWebViewClient(new WebViewClient() {
          @Override
          public boolean shouldOverrideUrlLoading(WebView view, String url) {
            return false;
          }
        });

@rakeshlanjewar rakeshlanjewar changed the title fixed javascript redirect #1197 [WIP][WEBVIEW] fixed javascript redirect #1197 Feb 20, 2019
@cyanglaz cyanglaz changed the title [WIP][WEBVIEW] fixed javascript redirect #1197 [webview_flutter][WIP]fixed javascript redirect #1197 Feb 23, 2019
@cyanglaz cyanglaz added the WIP label Feb 23, 2019
@rakeshlanjewar rakeshlanjewar changed the title [webview_flutter][WIP]fixed javascript redirect #1197 [webview_flutter]fixed javascript redirect #1197 Mar 4, 2019
@phaniteja1
Copy link

Please fix the checks and merge this pr

@realcarlos
Copy link

@zoechi could you help ,bro? ☝️

@amirh
Copy link
Contributor

amirh commented Mar 29, 2019

I'm not sure exactly how overriding shouldOverrideUrlLoading fixes redirects, but I believe the same affect should have been achieved by #1236.

@rakeshlanjewarwork Is this PR still needed?

@rakeshlanjewar
Copy link
Author

rakeshlanjewar commented Mar 30, 2019

@amirh , I am not that much confident about PR, But it works and this PR fixes the issue.
You can merge PR if you think its correct or close the PR.

Please work on keyboard issue!

Thanks!

@amirh
Copy link
Contributor

amirh commented Mar 30, 2019

@rakeshlanjewarwork what issue is this PR fixes? is that issue happening on the latest webview version? (if not, please close this PR).

@rakeshlanjewar
Copy link
Author

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants