This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_dynamic_links] fix dynamic link crash when creating shortlink if warnings are null #1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
CLAs look good, thanks! |
bparrishMines
changed the title
bparrishMines
added
bugfix
submit queue
Contributor
bparrishMines
left a comment
bparrishMines
left a comment
There was a problem hiding this comment.
Hi @ponnamkarthik,
Thanks for the contribution! Everything looks good.
Can you update the formatting to get the test to pass? After that, I can submit this.
bparrishMines
added a commit
that referenced
this pull request
Mar 4, 2019
romaluca
pushed a commit
to romaluca/plugins
that referenced
this pull request
Mar 6, 2019
…nk if warnings are null (flutter#1142) * fix dynamic link crash when creating shortlink if warnings are null * fix dynamic link crash when creating shortlink if warnings are null * fix dynamic link crash when creating shortlink if warnings are null * ios crash if warnings are null * ios crash if warnings are null * Formatting
romaluca
pushed a commit
to romaluca/plugins
that referenced
this pull request
Mar 6, 2019
jonasbark
pushed a commit
to jonasbark/plugins
that referenced
this pull request
Mar 11, 2019
* commit '9017d6e7f867af278edd7e8e584d52524f37443f': (408 commits) [webview_flutter]Allow specifying a navigation delegate(Android and Dart). (flutter#1236) Allow specifying a navigation delegate (iOS implementation). (flutter#1323) Change build link in contributors site to cirrus (flutter#1327) [image_picker] Update versioning for flutter#1268 (flutter#1326) [image_picker] remove unnecessary camera permmision (flutter#1268) Exclude longPress from semantics (flutter#1324) [in_app_purchase] refactoring and tests (flutter#1322) [in_app_purchase] Adds Dart BillingClient APIs for loading purchases (flutter#1286) [connectivity] Update README.md (flutter#1201) [camera] Fixes #28350 (flutter#1261) [cloud_functions] Specify version for CocoaPod and handle null regions gracefully (flutter#1316) [in_app_purchase]retrieve receipt (flutter#1303) [firebase_analytics] Add resetAnalyticsData method (flutter#1311) trackCameraPosition is inferred from GoogleMap.onCameraMove (flutter#1314) [google_maps_flutter]ChangeNotifier is replaced with granular callbacks (flutter#1302) [video_player]Do not divide by zero (flutter#793) [firebase_dynamic_links] Version bump for firebase_dynamic_links PR flutter#1142 (flutter#1309) [firebase_dynamic_links] fix dynamic link crash when creating shortlink if warnings are null (flutter#1142) Fix typo in RewardedVideoAdd sample (flutter#927) Add my name to firebase_performance and firebase_dynamic_links owners (flutter#1300) ... # Conflicts: # packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java # packages/camera/ios/Classes/CameraPlugin.m # packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m # packages/image_picker/android/build.gradle # packages/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java
Contributor
|
Hello! Why is this fatal error fix not released yet? Thank you! |
Contributor
|
@ninnepinne Looks like I may have forgotten to publish or it didn't go through. Thanks for pointing this out. Latest version is now published. |
Contributor
|
@bparrishMines Thank you very much! |
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…nk if warnings are null (flutter#1142) * fix dynamic link crash when creating shortlink if warnings are null * fix dynamic link crash when creating shortlink if warnings are null * fix dynamic link crash when creating shortlink if warnings are null * ios crash if warnings are null * ios crash if warnings are null * Formatting
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.