Skip to content

[vector_graphics_compiler] Set the m4_10 (Z scale) value to 1 when constructing an AffineMatrix from an SVG matrix #9813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Aug 15, 2025
Merged

[vector_graphics_compiler] Set the m4_10 (Z scale) value to 1 when constructing an AffineMatrix from an SVG matrix #9813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afb77ce
[vector_graphics_compiler] Set the m4_10 (Z scale) value to 1 when co…
jason-simmons Aug 14, 2025
89e7a16
Update end-to-end test expectation
jason-simmons Aug 14, 2025
a9bda1f
version and changelog
jason-simmons Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vector_graphics_compiler/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT
## 1.1.18

* Updates minimum supported SDK version to Flutter 3.27/Dart 3.6.
* Fixes SVG matrix parsing to explicitly set the Z scale value.

## 1.1.17

Expand Down
2 changes: 1 addition & 1 deletion packages/vector_graphics_compiler/lib/src/svg/parsers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ AffineMatrix _parseSvgMatrix(List<double> params, AffineMatrix current) {
final double e = params[4];
final double f = params[5];

return AffineMatrix(a, b, c, d, e, f).multiplied(current);
return AffineMatrix(a, b, c, d, e, f, 1.0).multiplied(current);
}

AffineMatrix _parseSvgSkewX(List<double> params, AffineMatrix current) {
Expand Down
2 changes: 1 addition & 1 deletion packages/vector_graphics_compiler/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: vector_graphics_compiler
description: A compiler to convert SVGs to the binary format used by `package:vector_graphics`.
repository: https://github.com/flutter/packages/tree/main/packages/vector_graphics_compiler
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+vector_graphics%22
version: 1.1.17
version: 1.1.18

executables:
vector_graphics_compiler:
Expand Down
2 changes: 1 addition & 1 deletion packages/vector_graphics_compiler/test/end_to_end_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ void main() {
0.0,
0.0,
0.0,
3.0,
1.0,
0.0,
30.0,
40.0,
Expand Down
6 changes: 3 additions & 3 deletions packages/vector_graphics_compiler/test/parsers_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,12 @@ void main() {

expect(
parseTransform('matrix(1.5, 2.0, 3.0, 4.0, 5.0, 6.0)'),
const AffineMatrix(1.5, 2.0, 3.0, 4.0, 5.0, 6.0),
const AffineMatrix(1.5, 2.0, 3.0, 4.0, 5.0, 6.0, 1.0),
);

expect(
parseTransform('matrix(1.5, 2.0, 3.0, 4.0, 5.0, 6.0 )'),
const AffineMatrix(1.5, 2.0, 3.0, 4.0, 5.0, 6.0),
const AffineMatrix(1.5, 2.0, 3.0, 4.0, 5.0, 6.0, 1.0),
);

expect(
Expand Down Expand Up @@ -198,7 +198,7 @@ void main() {
0.70711, -0.70711, //
0.70711, 0.70711, //
-640.89, 452.68, //
0.70711, //
1.0, //
),
);
});
Expand Down