Skip to content

Add review agent style guidelines to .gemini/styleguide.md #9805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Aug 14, 2025
Merged

Add review agent style guidelines to .gemini/styleguide.md #9805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .gemini/styleguide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,13 @@ auto-formatter, for each language, as described in
- PR descriptions should include the Pre-Review Checklist from
[the PR template](https://github.com/flutter/packages/blob/main/.github/PULL_REQUEST_TEMPLATE.md),
with all of the steps completed.

## Review Agent Guidelines

When providing a summary, the review agent must adhere to the following principles:
- **Be Objective:** Focus on a neutral, descriptive summary of the changes. Avoid subjective value judgments
like "good," "bad," "positive," or "negative." The goal is to report what the code does, not to evaluate it.
Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "not to evaluate it" may end up swinging too far the other way; we'll have to see if it stops pointing out high-level issues (e.g., insufficient testing).

- **Use Code as the Source of Truth:** Base all summaries on the code diff. Do not trust or rephrase the PR
description, which may be outdated or inaccurate. A summary must reflect the actual changes in the code.
- **Be Concise:** Generate summaries that are brief and to the point. Focus on the most significant changes,
and avoid unnecessary details or verbose explanations. This ensures the feedback is easy to scan and understand.