Skip to content

Resolve android_build_all_packages Warnings #9643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Jul 25, 2025
Merged

Resolve android_build_all_packages Warnings #9643

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4654f10
can build legacy apk now
jesswrd Jul 17, 2025
75974ba
can run build legacy command now
jesswrd Jul 17, 2025
c19e929
files and directories checked separately
jesswrd Jul 17, 2025
5fd1342
reverted changes in create_all_packages_app_command
jesswrd Jul 22, 2025
871b335
reverted Java and Kotlin compile options
jesswrd Jul 22, 2025
4e59a51
added versioning updates to README
jesswrd Jul 22, 2025
73b6c25
updated README
jesswrd Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .ci/legacy_project/all_packages/android/app/build.gradle
View file
Open in desktop
Comment thread
jesswrd marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,15 @@ android {
namespace = "com.example.all_packages"
compileSdkVersion flutter.compileSdkVersion

compileOptions {
Comment thread
jesswrd marked this conversation as resolved.
Outdated
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}

kotlinOptions {
jvmTarget = JavaVersion.VERSION_17.toString()
}

defaultConfig {
applicationId "com.example.all_packages"
minSdkVersion flutter.minSdkVersion
Expand Down
2 changes: 1 addition & 1 deletion .ci/legacy_project/all_packages/android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-all.zip
Comment thread
jesswrd marked this conversation as resolved.
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip
4 changes: 2 additions & 2 deletions .ci/legacy_project/all_packages/android/settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ pluginManagement {
// See https://github.com/flutter/flutter/blob/master/docs/ecosystem/Plugins-and-Packages-repository-structure.md#gradle-structure for more info.
plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version "8.3.0" apply false
id "org.jetbrains.kotlin.android" version "1.9.0" apply false
id "com.android.application" version "8.6.0" apply false
id "org.jetbrains.kotlin.android" version "2.1.0" apply false
}

include ":app"
12 changes: 7 additions & 5 deletions script/tool/lib/src/create_all_packages_app_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,15 @@ class CreateAllPackagesAppCommand extends PackageCommand {
for (final FileSystemEntity entity in source.listSync()) {
final String basename = entity.basename;
print('Replacing $basename with legacy version...');
if (entity is Directory) {
target.childDirectory(basename).deleteSync(recursive: true);
} else {
target.childFile(basename).deleteSync();
if (target.childDirectory(basename).existsSync()) {
if (entity is Directory) {
target.childDirectory(basename).deleteSync(recursive: true);
} else {
target.childFile(basename).deleteSync();
}
}
Comment thread
jesswrd marked this conversation as resolved.
Outdated
_copyDirectory(source: source, target: target);
}
_copyDirectory(source: source, target: target);
}

void _copyDirectory({required Directory target, required Directory source}) {
Expand Down