Skip to content

[rfw] Update tests to no longer depend on a Container pumped via testWidgets. #9063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Jun 17, 2025
Merged

[rfw] Update tests to no longer depend on a Container pumped via testWidgets. #9063

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4d6ea4
Update tests to no longer depend on a `Container` pumped via `testWid…
ksokolovskyi Apr 12, 2025
b9e0067
Merge branch 'main' into replace-container-by-view-in-rfw-tests
ksokolovskyi May 7, 2025
7bae80c
Revert changelog and version.
ksokolovskyi May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/rfw/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.0.32

* Updates tests to no longer depend on a `Container` pumped via `testWidgets`.

@stuartmorgan-g stuartmorgan-g May 7, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the test/ directory don't need changelog and version changes, so these should be reverted.

@ksokolovskyi ksokolovskyi May 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I've reverted this change in the latest commit.


## 1.0.31

* Updates minimum supported SDK version to Flutter 3.22/Dart 3.4.
Expand Down
2 changes: 1 addition & 1 deletion packages/rfw/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: rfw
description: "Remote Flutter widgets: a library for rendering declarative widget description files at runtime."
repository: https://github.com/flutter/packages/tree/main/packages/rfw
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+rfw%22
version: 1.0.31
version: 1.0.32

environment:
sdk: ^3.4.0
Expand Down
6 changes: 3 additions & 3 deletions packages/rfw/test/runtime_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,7 @@ void main() {
'''));
expect(
(runtime.build(
tester.element(find.byType(Container)),
tester.element(find.byType(View)),
const FullyQualifiedWidgetName(LibraryName(<String>['test']), 'stateless'),
data,
(String eventName, DynamicMap eventArguments) {},
Expand All @@ -913,7 +913,7 @@ void main() {
);
expect(
(runtime.build(
tester.element(find.byType(Container)),
tester.element(find.byType(View)),
const FullyQualifiedWidgetName(LibraryName(<String>['test']), 'stateful'),
data,
(String eventName, DynamicMap eventArguments) {},
Expand All @@ -922,7 +922,7 @@ void main() {
);
expect(
(runtime.build(
tester.element(find.byType(Container)),
tester.element(find.byType(View)),
const FullyQualifiedWidgetName(LibraryName(<String>['test']), 'switchy'),
data,
(String eventName, DynamicMap eventArguments) {},
Expand Down