[go_router_builder]: allow nullable String where try parse to enum #8736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'main' of https://github.com/CaoGiaHieu-dev/packages: Roll Flutter from 1659206 to 2e570ca (75 revisions) (#8731) Manual roll Flutter from 043b719 to 1659206 (19 revisions) (#8728) Manual roll Flutter from 911aa75 to 043b719 (#8693) Dependabot to update major and minor versions of test dependencies, ignore patch (#8712) [local_auth] Update to use flutter.targetSdkVersion (#8695) [go_router_builder]: Handle invaild params (#8405) [pigeon] Timestamp test steps in CI (#8716) [camera_android_camerax] Fix 90°-off preview rotation (#8629) [go_router] Secured empty matches in canPop (#8557) [tool] Update targetsdk version to 35 from 32 (#8694) [various] Bump androidx.test:core to 1.4.0 (#8710) [camera] Disable flaky tests (#8708) [url_launcher][web] Prevent browser from navigating when followLink isn't called (#8675) [various] Remove plugin-level `integration_test` dependencies (#8711) [ci] Lengthen custom tests timeout (#8715) # Conflicts: # packages/go_router_builder/example/lib/all_types.g.dart # packages/go_router_builder/example/lib/main.g.dart # packages/go_router_builder/example/lib/stateful_shell_route_initial_location_example.g.dart # packages/go_router_builder/lib/src/route_config.dart # packages/go_router_builder/test_inputs/enum_parameter.dart.expect # packages/go_router_builder/test_inputs/iterable_with_enum.dart.expect
CaoGiaHieu-dev
requested review from
bparrishMines,
camsim99,
gmackall,
loic-sharma,
matanlurey,
reidbaker and
vashworth
as code owners
CaoGiaHieu-dev
requested review from
chunhtai,
ditman,
stuartmorgan-g and
tarrinneal
as code owners
github-actions
bot
added
p: pigeon
p: go_router_builder
p: go_router
p: camera
p: file_selector
p: flutter_plugin_android_lifecycle
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: local_auth
p: path_provider
p: quick_actions
platform-android
platform-ios
platform-web
p: webview_flutter
p: video_player
p: url_launcher
p: shared_preferences
p: interactive_media_ads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact of this pr #8405 , params with required enum cannot parse
Fixed : flutter/flutter#164354
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.