Skip to content

[pigeon] Timestamp test steps in CI #8716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Feb 26, 2025
Merged

[pigeon] Timestamp test steps in CI #8716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 31 additions & 17 deletions packages/pigeon/tool/shared/test_runner.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,41 +22,46 @@ Future<void> runTests(
}) async {
final String baseDir = p.dirname(p.dirname(Platform.script.toFilePath()));
if (runGeneration) {
await _runGenerate(baseDir);
await _runGenerate(baseDir, ciMode: ciMode);
}

if (runFormat) {
await _runFormat(baseDir);
await _runFormat(baseDir, ciMode: ciMode);
}

await _runTests(testsToRun, ciMode: ciMode);

if (includeOverflow) {
await _runGenerate(baseDir, includeOverflow: true);
await _runGenerate(baseDir, ciMode: ciMode, includeOverflow: true);

// TODO(tarrinneal): Remove linux filter once overflow class is added to gobject generator.
// https://github.com/flutter/flutter/issues/152916
await _runTests(testsToRun
.where((String test) =>
test.contains('integration') && !test.contains('linux'))
.toList());
await _runTests(
testsToRun
.where((String test) =>
test.contains('integration') && !test.contains('linux'))
.toList(),
ciMode: ciMode);

if (!ciMode) {
await _runGenerate(baseDir);
await _runGenerate(baseDir, ciMode: ciMode);
}

if (!ciMode && (runFormat || !runGeneration)) {
await _runFormat(baseDir);
await _runFormat(baseDir, ciMode: ciMode);
}
}
}

// Pre-generate the necessary common output files.
Future<void> _runGenerate(String baseDir,
{bool includeOverflow = false}) async {
Future<void> _runGenerate(
String baseDir, {
required bool ciMode,
bool includeOverflow = false,
}) async {
// TODO(stuartmorgan): Consider making this conditional on the specific
// tests being run, as not all of them need these files.
print('# Generating platform_test/ output...');
_printHeading('Generating platform_test/ output', ciMode: ciMode);
final int generateExitCode = await generateTestPigeons(
baseDir: baseDir,
includeOverflow: includeOverflow,
Expand All @@ -68,8 +73,8 @@ Future<void> _runGenerate(String baseDir,
}
}

Future<void> _runFormat(String baseDir) async {
print('Formatting generated output...');
Future<void> _runFormat(String baseDir, {required bool ciMode}) async {
_printHeading('Formatting generated output', ciMode: ciMode);
final int formatExitCode =
await formatAllFiles(repositoryRoot: p.dirname(p.dirname(baseDir)));
if (formatExitCode != 0) {
Expand All @@ -80,13 +85,12 @@ Future<void> _runFormat(String baseDir) async {

Future<void> _runTests(
List<String> testsToRun, {
bool ciMode = true,
required bool ciMode,
}) async {
for (final String test in testsToRun) {
final TestInfo? info = testSuites[test];
if (info != null) {
print('##############################');
print('# Running $test');
_printHeading('Running $test', ciMode: ciMode);
final int testCode = await info.function(ciMode: ciMode);
if (testCode != 0) {
print('# Failed, exit code: $testCode');
Expand All @@ -100,3 +104,13 @@ Future<void> _runTests(
}
}
}

void _printHeading(String heading, {required bool ciMode}) {
String timestamp = '';
if (ciMode) {
final DateTime now = DateTime.now();
timestamp = ' [start time ${now.hour}:${now.minute}:${now.second}]';
}
print('##############################');
print('# $heading$timestamp');
}