Skip to content

Conversation

@ValentinVignal
Copy link
Contributor

The android package manipulates disposable objects. This PR activate leak testing to make sure disposable objects are correctly disposed.

See the documentation: https://github.com/dart-lang/leak_tracker/blob/main/doc%2Fleak_tracking%2FDETECT.md

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ValentinVignal
Copy link
Contributor Author

Since I modified only the tests, I think this PR is eligible for the tags override: no versioning needed and override: no changelog needed

@ValentinVignal
Copy link
Contributor Author

cc @polina-c

@polina-c polina-c added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jan 5, 2025
@ValentinVignal ValentinVignal force-pushed the in-app-purchase/activate-leak-testing branch from 55107ac to 2542b9b Compare January 15, 2025 13:46
@ValentinVignal ValentinVignal force-pushed the in-app-purchase/activate-leak-testing branch from 2542b9b to 886148b Compare January 18, 2025 05:22
@ValentinVignal
Copy link
Contributor Author

Any feedback on the PR @gmackall ?

Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay

…ivate-leak-testing

# Conflicts:
#	packages/in_app_purchase/in_app_purchase_android/pubspec.yaml
@ValentinVignal ValentinVignal added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2025
@auto-submit auto-submit bot merged commit d0320ea into flutter:main Jan 31, 2025
77 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 5, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Feb 5, 2025
flutter/packages@02c6fef...e6ce02c

2025-02-05 [email protected] [vector_graphics]
Allow transition between placeholder and loaded image to have an
animation (flutter/packages#8195)
2025-02-04 [email protected] [flutter_markdown] Make custom table
column alignments work when text wraps (flutter/packages#8340)
2025-02-04 [email protected]
[interactive_media_ads] Adds internal wrapper for iOS native
`IMAAdPodInfo` (flutter/packages#8429)
2025-02-03 [email protected] [pigeon] reorg generator files
(flutter/packages#8532)
2025-02-03 [email protected] [pigeon] [swift] Fix `PigeonError`
sendability conformance in Swift 6 (flutter/packages#8302)
2025-02-03 [email protected] Roll Flutter from
b007899 to 8e2a6fc (61 revisions) (flutter/packages#8556)
2025-02-03 [email protected]
[google_maps_flutter] Support for Ground Overlay - platform interface
(flutter/packages#8518)
2025-01-31 [email protected] [tool] Add
--xcode-warnings-exceptions flag (flutter/packages#8524)
2025-01-31 [email protected] [tool] Ensure that injected
dependency overrides are sorted (flutter/packages#8542)
2025-01-31 [email protected] [vector_graphics] Revert leak
tracker change (flutter/packages#8544)
2025-01-31 [email protected] [shared_preferences_tool] Loosen
vm_service constraint to allow for 15 (flutter/packages#8539)
2025-01-31 [email protected]
[in_app_purchase] Activate leak testing for android
(flutter/packages#8369)
2025-01-31 [email protected] [flutter_markdown] Allow tables to be
scrollable with IntrinsicColumnWidth (flutter/packages#8526)
2025-01-30 [email protected] Update CODEOWNERS for pkg:animations
(flutter/packages#8534)
2025-01-30 [email protected] Roll Flutter from
c1ffaa9 to b007899 (43 revisions) (flutter/packages#8527)
2025-01-30 [email protected] [video_player_web] Adjust Web
implementation to the new platform interface (flutter/packages#8528)
2025-01-30 [email protected] [shared_preferences] Exposed
SharedPreferencesOptions. (flutter/packages#8530)
2025-01-29 [email protected] Re-land [shared_preferences] Add
shared preferences devtool (flutter/packages#8531)
2025-01-29 [email protected]
[in_app_purchase_storekit] Add Swift Package Manager compatibility
(flutter/packages#8469)
2025-01-29 [email protected] Revert "Re-land [shared_preferences]
Add shared preferences devtool" (flutter/packages#8529)
2025-01-29 [email protected]
[go_router_builder] Fixes trailing `?` by comparing iterables
(flutter/packages#8521)
2025-01-29 [email protected] [tool] Refactor
args of strings or YAML file lists (flutter/packages#8513)
2025-01-28 [email protected] [go_router]
Add missing await keyword to onTap callback in the code example in
`navigation.md` (flutter/packages#8343)
2025-01-28 [email protected] Re-land [shared_preferences] Add
shared preferences devtool (flutter/packages#8519)
2025-01-28 [email protected]
[vector_graphics] Fix memory leaks and activate leak testing
[prod-leak-fix] (flutter/packages#8373)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
The android package manipulates disposable objects. This PR activate leak testing to make sure disposable objects are correctly disposed.

See the documentation: https://github.com/dart-lang/leak_tracker/blob/main/doc%2Fleak_tracking%2FDETECT.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
The android package manipulates disposable objects. This PR activate leak testing to make sure disposable objects are correctly disposed.

See the documentation: https://github.com/dart-lang/leak_tracker/blob/main/doc%2Fleak_tracking%2FDETECT.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: in_app_purchase platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants