Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 9, 2024

If the flutter test run takes more than 10 minutes (default timeout is 12 minutes) take a screenshot and attach to the logs directory.

Helped debug flutter/flutter#153578 (comment).

Probably flutter test should have a screenshot option similar to flutter drive, but at the moment it doesn't.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Nov 9, 2024
@jmagman jmagman marked this pull request as ready for review November 12, 2024 00:26
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

for (final String target in individualRunTargets) {
final int exitCode = await processRunner.runAndStream(
final Timer timeoutTimer = Timer(const Duration(minutes: 10), () async {
printError('Test is taking a long time, taking screenshot...');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe printWarning?

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2024
@auto-submit auto-submit bot merged commit fc4adc7 into flutter:main Nov 18, 2024
77 checks passed
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2024
sinyu1012 added a commit to sinyu1012/packages that referenced this pull request Nov 19, 2024
* main:
  [ci] Take screenshot when native drive test is taking longer than 10 minutes (flutter#8050)
  Applied Gradle Plugins Declaratively for Most Remaining Plugin Example Apps (Part 3) (flutter#8037)
  [pigeon]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.10 to 2.0.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter#7867)
  [gradle]: Bump androidx.test.ext:junit-ktx from 1.1.5 to 1.2.1 in /packages/shared_preferences/shared_preferences_android/android (flutter#8097)
  [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.20 to 2.0.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter#7869)
  [gradle]: Bump org.hamcrest:hamcrest from 2.2 to 3.0 in /packages/espresso/android (flutter#8092)
  [pigeon]: Bump io.mockk:mockk from 1.13.12 to 1.13.13 in /packages/pigeon/platform_tests/test_plugin/android (flutter#7868)
  [shared_pref]: Bump io.mockk:mockk from 1.13.12 to 1.13.13 in /packages/shared_preferences/shared_preferences_android/android (flutter#7866)
  Add autosubmit label to dependabot PRs (flutter#8101)
  Roll Flutter from 0e2d55e to b3818f6 (23 revisions) (flutter#8118)
  [gradle]: Bump org.mockito.kotlin:mockito-kotlin from 4.1.0 to 5.4.0 in /packages/interactive_media_ads/android (flutter#8095)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 19, 2024
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 19, 2024
flutter/packages@c1eabf5...fc4adc7

2024-11-18 [email protected] [ci] Take screenshot when native drive test
is taking longer than 10 minutes (flutter/packages#8050)
2024-11-18 [email protected] Applied Gradle Plugins Declaratively
for Most Remaining Plugin Example Apps (Part 3) (flutter/packages#8037)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [pigeon]:
Bump org.jetbrains.kotlin:kotlin-bom from 1.8.10 to 2.0.21 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#7867)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump androidx.test.ext:junit-ktx from 1.1.5 to 1.2.1 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#8097)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [pigeon]:
Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.20 to 2.0.21 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#7869)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump org.hamcrest:hamcrest from 2.2 to 3.0 in /packages/espresso/android
(flutter/packages#8092)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [pigeon]:
Bump io.mockk:mockk from 1.13.12 to 1.13.13 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#7868)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com
[shared_pref]: Bump io.mockk:mockk from 1.13.12 to 1.13.13 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#7866)
2024-11-18 [email protected] Add autosubmit label to dependabot PRs
(flutter/packages#8101)
2024-11-18 [email protected] Roll Flutter from
0e2d55e to b3818f6 (23 revisions) (flutter/packages#8118)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants