Skip to content

[vector_garphics] fix execution on the web with WebAssembly #7991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Oct 31, 2024
Merged

[vector_garphics] fix execution on the web with WebAssembly #7991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/vector_graphics/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.1.13

* Fix execution on the web with WebAssembly.

## 1.1.12

* Transfers the package source from https://github.com/dnfield/vector_graphics
Expand Down
2 changes: 1 addition & 1 deletion packages/vector_graphics/lib/src/debug.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

export '_debug_io.dart' if (dart.library.html) '_debug_web.dart';
export '_debug_web.dart' if (dart.library.io) '_debug_io.dart';
2 changes: 1 addition & 1 deletion packages/vector_graphics/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ repository: https://github.com/flutter/packages/tree/main/packages/vector_graphi
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+vector_graphics%22
# See https://github.com/flutter/flutter/issues/157626 before publishing a new
# version.
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR ignored the TODO here, so vector_graphics is now mis-aligned with the vector_graphics_* versions. @jonahwilliams We need a versioning plan here ASAP.

Copy link
Contributor Author

@kevmoo kevmoo Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩 – sorry, folks

Copy link
Contributor

@jonahwilliams jonahwilliams Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought these weren't being auto published yet?

Copy link
Contributor Author

@kevmoo kevmoo Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got confirmed so I flipped the bit and assumed the robots would "do the right thing" 🤷

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought these weren't being auto published yet?

I needed to publish an initial version so that the pub.dev metadata (issue link, source link, etc.) would be correct. That literally landed yesterday at the end of my workday; I didn't expect someone to create a PR, ignore the comment on the version saying not to publish a new version yet, get it approved, and land it, all before I started my next day and could do a follow-up PR to mark them as unpublished.

version: 1.1.12
version: 1.1.13

environment:
sdk: ^3.4.0
Expand Down