[various] Remove multiDexEnabled #7956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had manually added `multiDexEnabled` to various plugin example apps over time to fix build failures, but it's not needed for plugins with a `minSdk` of 20+, and Flutter (and thus all of our plugins) requires 21+, so the setting is just cruft.
stuartmorgan-g
requested review from
bparrishMines,
camsim99,
gmackall,
reidbaker and
tarrinneal
as code owners
github-actions
bot
added
p: espresso
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: local_auth
platform-android
p: interactive_media_ads
reidbaker
approved these changes
Oct 29, 2024
gmackall
approved these changes
Oct 29, 2024
Contributor
|
Old man comment here. I remember when multidex started becoming an issue and I genuinely didn't think I would be doing android development still when we got to a point where it wasn't needed anymore. Woo |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 29, 2024
flutter/packages@e0c4f55...028027e 2024-10-29 [email protected] [various] Remove multiDexEnabled (flutter/packages#7956) 2024-10-28 [email protected] Roll Flutter from 5a11904 to 3fb95c7 (16 revisions) (flutter/packages#7948) 2024-10-28 [email protected] [interactive_media_ads] Adds internal wrapper for iOS native `IMACompanionAdSlot` and `IMACompanionDelegate` (flutter/packages#7889) 2024-10-27 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.2.1 to 4.2.2 (flutter/packages#7919) 2024-10-26 [email protected] Roll Flutter from 4faa4a4 to 5a11904 (67 revisions) (flutter/packages#7937) 2024-10-25 [email protected] Drop deprecated web library (flutter/packages#7926) 2024-10-25 [email protected] [video_player_web] Don't modify volume when muting video (flutter/packages#7845) 2024-10-25 [email protected] Roll Flutter (stable) from 2663184 to 6031040 (3 revisions) (flutter/packages#7930) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had manually added
multiDexEnabledto various plugin example apps over time to fix build failures, but it's not needed for plugins with aminSdkof 20+ (reference), and Flutter (and thus all of our plugins) requires 21+, so the setting is just cruft.