[video_player] Remove Android API 19 SSL handling #7876
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: removing code |
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
stuartmorgan-g
added
the
autosubmit
stuartmorgan-g
deleted the
video-player-android-remove-19-ssl-handling
branch
flutter/packages@2a1c477...b6f7e47 2024-10-21 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/path_provider/path_provider_android/android (flutter/packages#7895) 2024-10-18 [email protected] [in_app_purchase] Update iOS Pigeon for non-nullable generics (flutter/packages#7820) 2024-10-18 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `Ad` (flutter/packages#7880) 2024-10-18 [email protected] [video_player] Remove Android API 19 SSL handling (flutter/packages#7876) 2024-10-18 [email protected] [google_maps_android_flutter] Convert `Config.sdk` to `minSdk` in Robolectric tests and lower to `LOLLIPOP` (flutter/packages#7805) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
video_player_androidhas special code for API level 19 to enable some TLS versions that are supported but not enabled by default in that version (starting in 20, they are enabled by default). It has a min Flutter SDK version of 3.24 now, however, and 3.24 no longer supports API version 19, so we no longer need this code.See discussion in flutter/flutter#143649
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).