Skip to content

Conversation

@tbansod2018
Copy link

@tbansod2018 tbansod2018 commented Oct 9, 2024

not setting volume when muted

List which issues are fixed by this PR. You must list at least one issue.
Fixes #156444

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@tbansod2018 tbansod2018 requested a review from ditman as a code owner October 9, 2024 06:53
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Oct 9, 2024

Thanks for the contribution! You’ve haven't checked any boxes in the PR checklist, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when the checklist is complete please feel free to mark it as ready for review.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft October 9, 2024 12:02
@stuartmorgan-g stuartmorgan-g removed the request for review from ditman October 9, 2024 12:02
@tbansod2018 tbansod2018 changed the title not seting volume when muted [video_player]not seting volume when muted Oct 9, 2024
@tbansod2018 tbansod2018 marked this pull request as ready for review October 9, 2024 17:26
@stuartmorgan-g
Copy link
Collaborator

The purpose of the checklist is to ensure that all the necessary steps for a PR have been completed; you've checked a number of boxes for steps that you have not completed. All of these steps are required to move forward with review.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft October 9, 2024 17:40
@ditman ditman marked this as a duplicate of #7845 Oct 11, 2024
@ditman ditman marked this as not a duplicate of #7845 Oct 11, 2024
@ditman
Copy link
Member

ditman commented Oct 23, 2024

Closing in favor of #7845 which is closer to landing. Thanks for the contribution @tbansod2018!

@ditman ditman closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants