Skip to content

[flutter_markdown] Fix Scrollbars not showing up when multiple code blocks are in the same markdown. #6900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apwilson wants to merge 2 commits into from
Closed

[flutter_markdown] Fix Scrollbars not showing up when multiple code blocks are in the same markdown. #6900

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b3dfa6
[flutter_markdown] Fix issue where Scrollbars disappear when multiple…
apwilson Jun 10, 2024
c5f0597
Merge branch 'main' into apwilson-patch-2
apwilson Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/flutter_markdown/lib/src/builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ class MarkdownBuilder implements md.NodeVisitor {
final List<_TableElement> _tables = <_TableElement>[];
final List<_InlineElement> _inlines = <_InlineElement>[];
final List<GestureRecognizer> _linkHandlers = <GestureRecognizer>[];
final ScrollController _preScrollController = ScrollController();
String? _currentBlockTag;
String? _lastVisitedTag;
bool _isInBlockquote = false;
Expand Down Expand Up @@ -347,10 +346,11 @@ class MarkdownBuilder implements md.NodeVisitor {
child = builders[_blocks.last.tag!]!
.visitText(text, styleSheet.styles[_blocks.last.tag!]);
} else if (_blocks.last.tag == 'pre') {
final ScrollController preScrollController = ScrollController();
child = Scrollbar(
controller: _preScrollController,
controller: preScrollController,
child: SingleChildScrollView(
controller: _preScrollController,
controller: preScrollController,
scrollDirection: Axis.horizontal,
padding: styleSheet.codeblockPadding,
child: _buildRichText(delegate.formatText(styleSheet, text.text)),
Expand Down