Skip to content

[interactive_media_ads] Add SPM support #6756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
May 21, 2024
Merged

[interactive_media_ads] Add SPM support #6756

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1073c2b
[interactive_media_ads] Add SPM support
stuartmorgan-g May 17, 2024
692a93f
Autoformat
stuartmorgan-g May 17, 2024
b998b35
Merge branch 'main' into interactive-media-ads-spm
stuartmorgan-g May 21, 2024
e327143
Version bump
stuartmorgan-g May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/interactive_media_ads/ios/interactive_media_ads.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Downloaded by pub (not CocoaPods).
s.license = { :type => 'BSD', :file => '../LICENSE' }
s.author = { 'Flutter Dev Team' => 'flutter-dev@googlegroups.com' }
s.source = { :http => 'https://github.com/flutter/packages/tree/main/packages/interactive_media_ads/interactive_media_ads' }
s.source_files = 'Classes/**/*'
s.source_files = 'interactive_media_ads/Sources/interactive_media_ads/**/*.swift'
s.dependency 'Flutter'
s.platform = :ios, '12.0'

Expand All @@ -25,5 +25,5 @@ Downloaded by pub (not CocoaPods).
'LD_RUNPATH_SEARCH_PATHS' => '/usr/lib/swift',
}
s.swift_version = '5.0'
s.resource_bundles = {'interactive_media_ads_privacy' => ['Resources/PrivacyInfo.xcprivacy']}
s.resource_bundles = {'interactive_media_ads_privacy' => ['interactive_media_ads/Sources/interactive_media_ads/Resources/PrivacyInfo.xcprivacy']}

@vashworth vashworth May 17, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to move the PrivacyInfo.xcprivacy out of the Resources folder to make it inline with the create templates?

FYI I just updated the instructions to reflect that: flutter/flutter#146256 (comment)

@stuartmorgan-g stuartmorgan-g May 20, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong feelings for our own plugins; the layout is pretty much arbitrary. The main reason to move it in the template was to make it easy to have a single commented-out line that's specific to the privacy manifest, which doesn't matter in our actual plugins.

end
28 changes: 28 additions & 0 deletions packages/interactive_media_ads/ios/interactive_media_ads/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
// swift-tools-version: 5.9
// The swift-tools-version declares the minimum version of Swift required to build this package.

// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import PackageDescription

let package = Package(
name: "interactive_media_ads",
platforms: [
.iOS("12.0")
],
products: [
.library(name: "interactive-media-ads", targets: ["interactive_media_ads"])
],
dependencies: [],
targets: [
.target(
name: "interactive_media_ads",
dependencies: [],
resources: [
.process("Resources")
]
)
]
)
0 ...s/Classes/InteractiveMediaAdsPlugin.swift → ...media_ads/InteractiveMediaAdsPlugin.swift
View file
Open in desktop
File renamed without changes.
0 ...a_ads/ios/Resources/PrivacyInfo.xcprivacy → ...media_ads/Resources/PrivacyInfo.xcprivacy
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions packages/interactive_media_ads/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ description: A Flutter plugin for using the Interactive Media Ads SDKs on Androi
repository: https://github.com/flutter/packages/tree/main/packages/interactive_media_ads
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+interactive_media_ads%22
version: 0.0.1
publish_to: none

@bparrishMines bparrishMines May 20, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to set this to none?

@stuartmorgan-g stuartmorgan-g May 20, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you had intended to set it to none after the initial publish, until it was actually ready. If not, we can remove this and do incremental releases for everything.

@bparrishMines bparrishMines May 21, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is pre-1.0, I think it's fine to have incremental releases. We also plan to release the Android implementation early for feedback.


environment:
sdk: ^3.2.3
Expand Down