[url_launcher] Add Swift Package Manager support #6677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
approved these changes
May 7, 2024
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
LGTM but consider also getting a review from @vashworth as my understanding of SPM is still shaky
vashworth
reviewed
May 8, 2024
| s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' } | ||
| s.swift_version = '5.0' | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
formatting: Add back end of line
Collaborator
Author
There was a problem hiding this comment.
My editor automatically removes blank lines at the end of the file; I don't think we should keep them.
(This isn't a file without an EOL; my editor fixes those automatically too. And GitHub would show a warning marker in the diff.)
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 13, 2024
flutter/packages@6c4482a...1412041 2024-05-13 [email protected] [in_app_purchase] Update country code Android example (flutter/packages#6722) 2024-05-13 [email protected] Roll Flutter from 1dfb46e to 1255435 (6 revisions) (flutter/packages#6723) 2024-05-13 [email protected] [camera] Change default Android implementation from `camera_android` to `camera_android_camerax` (flutter/packages#6629) 2024-05-13 [email protected] [image_picker_ios] Make all headers public for SwiftPM to keep inline with CocoaPods (flutter/packages#6707) 2024-05-12 [email protected] Roll Flutter from 2aa05c1 to 1dfb46e (3 revisions) (flutter/packages#6715) 2024-05-11 [email protected] Roll Flutter from 2bfb1b0 to 2aa05c1 (26 revisions) (flutter/packages#6713) 2024-05-10 [email protected] [quick_actions] Add Swift Package Manager support (flutter/packages#6682) 2024-05-10 [email protected] [url_launcher] Add Swift Package Manager support (flutter/packages#6677) 2024-05-10 [email protected] [Android][webview_flutter] Run integration tests on emulators running Android 34 (flutter/packages#6499) 2024-05-10 [email protected] [image_picker_android] - will fix crash on Android 12+ devices (flutter/packages#6691) 2024-05-10 [email protected] [camerax] Make fixes required to swap camera_android_camerax for camera_android (flutter/packages#6697) 2024-05-10 [email protected] Update .gitignore for Swift Package Manager (flutter/packages#6705) 2024-05-10 [email protected] [quick_actions_android] Switch to `Compat` version of `ShortcutManager` to support Google surfaces (flutter/packages#6638) 2024-05-10 [email protected] [local_auth_darwin] Adds Swift Package Manager compatibility (flutter/packages#6708) 2024-05-10 [email protected] Roll Flutter from 00f4066 to 2bfb1b0 (9 revisions) (flutter/packages#6706) 2024-05-09 [email protected] [go_router] Feat add route redirect shellroutes (#114559) (flutter/packages#6432) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
Adds SPM support for both iOS and macOS. Also opportunistically updates the unit tests for macOS to match the changes made in flutter#4959 since I noticed that they were failing when running locally. This will prevent issues when we update CI in the future. Fixes flutter/flutter#146916
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SPM support for both iOS and macOS.
Also opportunistically updates the unit tests for macOS to match the changes made in #4959 since I noticed that they were failing when running locally. This will prevent issues when we update CI in the future.
Fixes flutter/flutter#146916
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).