Skip to content

[google_sign_in_web] README.md typo #6642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 11 commits into from
Jun 17, 2024
Merged

[google_sign_in_web] README.md typo #6642

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a976d27
README.md typo
Jerinji2016 May 4, 2024
c0aa07f
Update CHANGELOG.md
Jerinji2016 May 9, 2024
fc18bee
Update pubspec.yaml
Jerinji2016 May 9, 2024
df4e94b
Merge branch 'main' into patch-1
Jerinji2016 May 9, 2024
a4c8efa
Update CHANGELOG.md
Jerinji2016 May 9, 2024
c649577
Update CHANGELOG.md
Jerinji2016 May 9, 2024
89bb2b3
Merge branch 'main' into patch-1
Jerinji2016 May 12, 2024
ec7fab4
Merge branch 'main' into patch-1
Jerinji2016 May 18, 2024
5fc50a7
Merge branch 'main' into patch-1
Jerinji2016 May 24, 2024
8b46e5c
Update CHANGELOG.md
Jerinji2016 Jun 13, 2024
51b2a5a
Merge branch 'main' into patch-1
Jerinji2016 Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/google_sign_in/google_sign_in_web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 0.12.4+1
* Fixed README.md typo
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the changeliog style guide linked from the PR checklist.

Copy link
Contributor Author

@Jerinji2016 Jerinji2016 May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I need to change version to NEXT.
Should I revert the version change in pubspec too?

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend reading the FAQ section of the linked documentation about READMEs and version updates. Also, you haven't addressed the CHANGELOG message style issues raised in the comment you are replying to.

Please read the documentation linked from the PR checklist; the reason we have the checklist is to provide guidance and links to relevant documentation.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still doesn't use the correct verb form, and still doesn't have a period, so none of the style issues have been resolved.


## 0.12.4

* Updates dependencies to `web: ^0.5.0` and `google_identity_services_web: ^0.3.1`.
Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/google_sign_in_web/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ plugin required a major version update.

The **Google Sign-In JavaScript for Web JS SDK** is set to be deprecated after
March 31, 2023. **Google Identity Services (GIS) SDK** is the new solution to
quickly and easily sign users into your app suing their Google accounts.
quickly and easily sign users into your app using their Google accounts.

* In the GIS SDK, Authentication and Authorization are now two separate concerns.
* Authentication (information about the current user) flows will not
Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/google_sign_in_web/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for Google Sign-In, a secure authentication system
for signing in with a Google account on Android, iOS and Web.
repository: https://github.com/flutter/packages/tree/main/packages/google_sign_in/google_sign_in_web
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22
version: 0.12.4
version: 0.12.4+1

environment:
sdk: ^3.3.0
Expand Down