Skip to content

[tool] Check for test and flutter_test in non-dev dependencies #6472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Apr 10, 2024
Merged

[tool] Check for test and flutter_test in non-dev dependencies #6472

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b688139
updated readme and version
ekuleshov Apr 5, 2024
e0b43af
Merge remote-tracking branch 'refs/remotes/origin/main' into addition…
ekuleshov Apr 5, 2024
1b1add3
updated tests
ekuleshov Apr 5, 2024
50ab5a4
Merge remote-tracking branch 'refs/remotes/origin/main' into addition…
ekuleshov Apr 8, 2024
98de7d9
PR feedback
ekuleshov Apr 8, 2024
e273743
PR feedback
ekuleshov Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/css_colors/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a version change, which is why CI is failing.

Copy link
Contributor Author

@ekuleshov ekuleshov Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


* Updates minimum supported SDK version to Flutter 3.13/Dart 3.1.
* Moves flutter_test and test dependencies to dev_dependencies.

## 1.1.4

Expand Down
4 changes: 3 additions & 1 deletion packages/css_colors/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: css_colors
description: Defines constant dart:ui Color objects for CSS colors (for use in Flutter code).
repository: https://github.com/flutter/packages/tree/main/packages/css_colors
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+css_colors%22
version: 1.1.4
version: 1.1.4+1
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the end of https://dart.dev/tools/pub/versioning#semantic-versions. We follow the advice there about when to use (and not use) + in versions.

Copy link
Contributor Author

@ekuleshov ekuleshov Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


environment:
sdk: ^3.1.0
Expand All @@ -11,6 +11,8 @@ environment:
dependencies:
flutter:
sdk: flutter

dev_dependencies:
flutter_test:
sdk: flutter

Expand Down
4 changes: 4 additions & 0 deletions packages/web_benchmarks/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.2.1+1
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here.

Copy link
Contributor Author

@ekuleshov ekuleshov Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


* Moves flutter_test and test dependencies to dev_dependencies.

## 1.2.1

* Removes a few deprecated API usages.
Expand Down
10 changes: 6 additions & 4 deletions packages/web_benchmarks/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: web_benchmarks
description: A benchmark harness for performance-testing Flutter apps in Chrome.
repository: https://github.com/flutter/packages/tree/main/packages/web_benchmarks
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+web_benchmarks%22
version: 1.2.1
version: 1.2.1+1

environment:
sdk: ^3.3.0
Expand All @@ -12,18 +12,20 @@ dependencies:
collection: ^1.18.0
flutter:
sdk: flutter
flutter_test:
sdk: flutter
logging: ^1.0.2
meta: ^1.7.0
path: ^1.8.0
process: ">=4.2.4 <6.0.0"
shelf: ^1.2.0
shelf_static: ^1.1.0
test: ^1.19.5
web: ^0.5.0
webkit_inspection_protocol: ^1.0.0

dev_dependencies:
flutter_test:
sdk: flutter
test: ^1.19.5

topics:
- benchmarking
- performance
2 changes: 1 addition & 1 deletion script/tool/lib/src/pubspec_check_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ class PubspecCheckCommand extends PackageLoopingCommand {
}

// Ensure that dev-only dependencies aren't in `dependencies`.
const List<String> devOnlyDependencies = <String>['integration_test'];
const Set<String> devOnlyDependencies = <String>{'integration_test', 'test', 'flutter_test'};
// Non-published packages like pidgeon subpackages are allowed to violate
// the dev only dependencies rule.
if (pubspec.publishTo != 'none') {
Expand Down
13 changes: 11 additions & 2 deletions script/tool/test/pubspec_check_command_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1743,7 +1743,11 @@ ${_topicsSection()}
package.pubspecFile.writeAsStringSync('''
${_headerSection('a_package')}
${_environmentSection()}
${_dependenciesSection(<String>['integration_test: \n sdk: flutter'])}
${_dependenciesSection(<String>[
'integration_test: \n sdk: flutter',
'flutter_test: \n sdk: flutter',
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the existing tests are going to change to test more things, then the test descriptions need to change accordingly.

Copy link
Contributor Author

@ekuleshov ekuleshov Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated test name to 'fails when integration_test, flutter_test or test are used in non dev dependency'

'test: 1.0.0'
])}
${_devDependenciesSection()}
${_topicsSection()}
''');
Expand All @@ -1761,7 +1765,9 @@ ${_topicsSection()}
containsAllInOrder(<Matcher>[
contains(
'The following unexpected non-local dependencies were found:\n'
' test\n'
' integration_test\n'
' flutter_test\n'
'Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#Dependencies '
'for more information and next steps.'),
]),
Expand All @@ -1776,7 +1782,10 @@ ${_topicsSection()}
package.pubspecFile.writeAsStringSync('''
${_headerSection('a_package', publishable: false)}
${_environmentSection()}
${_dependenciesSection(<String>['integration_test: \n sdk: flutter'])}
${_dependenciesSection(<String>[
'integration_test: \n sdk: flutter',
'flutter_test: \n sdk: flutter'
])}
${_devDependenciesSection()}
${_topicsSection()}
''');
Expand Down