Skip to content

[ci] Run Windows Arm64 build tests post-submit #6166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Feb 21, 2024
Merged

[ci] Run Windows Arm64 build tests post-submit #6166

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
044417c
[ci] Run Windows Arm64 build tests post-submit
loic-sharma Feb 20, 2024
73c7ef3
Fix
loic-sharma Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1472,6 +1472,7 @@ targets:

- name: Windows_arm64 windows-build_all_packages master
recipe: packages/packages
presubmit: false
timeout: 30
bringup: true # https://github.com/flutter/flutter/issues/134083
properties:
Expand All @@ -1490,6 +1491,7 @@ targets:

- name: Windows_x64 windows-build_all_packages stable
recipe: packages/packages
presubmit: false
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was supposed to go on line 1510 instead (Win arm64 stable)?

If capacity is low, I would suggest just deleting that one instead. The chances of breaking only the Windows arm64 build of plugins only on stable seems extremely low, so we could halve our Windows arm64 usage for this repo with probably no appreciable impact on coverage.

Copy link
Member Author

@loic-sharma loic-sharma Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed!

The majority of Windows Arm64 capacity is used by Dart's tests, not Flutter's tests. I think keeping the Windows Arm64 stable test is fine unless you'd prefer to remove it.

My understanding is that the infra team would need to significantly increase their number of Windows Arm64 machines to also support the try pool, so for now they're skipping that.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably remove it absent some reason we believe it will catch actual issues that the other bot won't, but I don't feel strongly about it.

timeout: 30
properties:
target_file: windows_build_all_packages.yaml
Expand Down