[video_player] Fix pause infinite loop on completed

packages/video_player/video_player/CHANGELOG.md

@@ -1,8 +1,13 @@
 ## NEXT
 
+* Description of the change.
+
+## 2.8.3
+
 * Updates support matrix in README to indicate that iOS 11 is no longer supported.
 * Clients on versions of Flutter that still support iOS 11 can continue to use this
   package with iOS 11, but will not receive any further updates to the iOS implementation.
+* Fix infinite pause loop caused by on completed to call pause even when video is pause.
 
 ## 2.8.2
 

packages/video_player/video_player/lib/video_player.dart

@@ -460,7 +460,9 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> {
           // position=value.duration. Instead of setting the values directly,
           // we use pause() and seekTo() to ensure the platform stops playing
           // and seeks to the last frame of the video.
-          pause().then((void pauseResult) => seekTo(value.duration));
+          if (value.isPlaying) {
+            pause().then((void pauseResult) => seekTo(value.duration));
+          }
           value = value.copyWith(isCompleted: true);
         case VideoEventType.bufferingUpdate:
           value = value.copyWith(buffered: event.buffered);

packages/video_player/video_player/pubspec.yaml

@@ -3,7 +3,7 @@ description: Flutter plugin for displaying inline video with other Flutter
   widgets on Android, iOS, and web.
 repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
-version: 2.8.2
+version: 2.8.3
 
 environment:
   sdk: ">=3.1.0 <4.0.0"

packages/video_player/video_player/test/video_player_test.dart

@@ -1246,7 +1246,7 @@ void main() {
 
     bool currentIsCompleted = controller.value.isCompleted;
 
-    final void Function() isCompletedTest = expectAsync0(() {}, count: 2);
+    final void Function() isCompletedTest = expectAsync0(() {});
     final void Function() isNoLongerCompletedTest = expectAsync0(() {});
     bool hasLooped = false;