Skip to content

[tool] Add support for .java, .gradle, .sh, and .m files… #5567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 9 commits into from
Dec 13, 2023
Merged

[tool] Add support for .java, .gradle, .sh, and .m files… #5567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8af458d
[tool] Add support for `.java`, `.gradle`, `.sh`, and `.m` files to `…
mike-v2 Dec 4, 2023
576fc7b
Fix 'gradle' should not be listed as a language
mike-v2 Dec 4, 2023
83a76b7
Add tests to ensure different file types are updated properly
mike-v2 Dec 5, 2023
c13043e
Run tests in a 'for' loop
mike-v2 Dec 6, 2023
bc628be
Re-add recognition of '.cc' files as 'c++' language
mike-v2 Dec 12, 2023
2a0a18a
Replace 'fileName' with 'filename'
mike-v2 Dec 12, 2023
0ec0bd6
Fix test case for extracting excerpts from '.cc' files
mike-v2 Dec 12, 2023
9c5ff63
Convert 'testInjection' function arguments to named arguments
mike-v2 Dec 12, 2023
dde5ebf
Change 'for...in' loop to 'forEach'
mike-v2 Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions script/tool/lib/src/update_excerpts_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,12 @@ class UpdateExcerptsCommand extends PackageLoopingCommand {
case '.cpp':
language = 'c++';
break;
case '.m':
language = 'objectivec';
break;
Comment on lines 146 to +151
Copy link
Contributor

@tarrinneal tarrinneal Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan Seems like we don't have support for header files for either language. I'm not sure there's a simple solution though.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Dec 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. That would need either more special casing here, or a more generalized solution (like a mapping from extensions to the set of allowed languages).

case '.gradle':
language = 'groovy';
break;
default:
language = extension.substring(1);
break;
Expand Down Expand Up @@ -239,6 +245,9 @@ class UpdateExcerptsCommand extends PackageLoopingCommand {
case 'js':
case 'kotlin':
case 'rfwtxt':
case 'java':
case 'groovy':
case 'objectivec':
case 'swift':
prefix = '// ';
break;
Expand All @@ -255,6 +264,9 @@ class UpdateExcerptsCommand extends PackageLoopingCommand {
case 'yaml':
prefix = '# ';
break;
case 'sh':
prefix = '# ';
break;
}
final String startRegionMarker = '$prefix#docregion $section$suffix';
final String endRegionMarker = '$prefix#enddocregion $section$suffix';
Expand Down
Loading