Skip to content

[flutter_markdown] Strip leading whitespace from list items #5294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 9 commits into from
Nov 6, 2023
Merged

[flutter_markdown] Strip leading whitespace from list items #5294

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7f132e1
Fixes Flutter issue #134847
krozett Nov 2, 2023
436f8a1
Complying with version and changelog policy
krozett Nov 2, 2023
c5fda24
Fix formatting
krozett Nov 2, 2023
d46dbdd
Merge branch 'main' into main
krozett Nov 2, 2023
950d44a
Test
krozett Nov 3, 2023
13708ec
Merge branch 'main' into main
krozett Nov 3, 2023
e387e90
Merge branch 'main' of github.com:krozett/packages
krozett Nov 3, 2023
3cf7bed
Merge branch 'main' into main
domesticmouse Nov 3, 2023
d86bd5e
Fix typo
krozett Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/flutter_markdown/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.6.18+2

* Removes leading whitspace from list items.

## 0.6.18+1

* Fixes a typo in README.
Expand Down
3 changes: 2 additions & 1 deletion packages/flutter_markdown/lib/src/builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,8 @@ class MarkdownBuilder implements md.NodeVisitor {
// Leading spaces in paragraph or list item are ignored
// https://github.github.com/gfm/#example-192
// https://github.github.com/gfm/#example-236
if (const <String>['ul', 'ol', 'p', 'br'].contains(_lastVisitedTag)) {
if (const <String>['ul', 'ol', 'li', 'p', 'br']
.contains(_lastVisitedTag)) {
text = text.replaceAll(leadingSpacesPattern, '');
}

Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_markdown/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Markdown renderer for Flutter. Create rich text output,
formatted with simple Markdown tags.
repository: https://github.com/flutter/packages/tree/main/packages/flutter_markdown
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_markdown%22
version: 0.6.18+1
version: 0.6.18+2

environment:
sdk: ">=3.0.0 <4.0.0"
Expand Down