-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[quick_actions] convert to pigeon #5159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
409cd34
swift
tarrinneal cbbd121
doc
tarrinneal 9eaaaf2
Merge branch 'main' of github.com:flutter/packages into QA-pigeon
tarrinneal f23b103
Merge branch 'main' of github.com:flutter/packages into QA-pigeon
tarrinneal 01599f2
nits and test fixes
tarrinneal 975dcb2
Merge branch 'main' of github.com:flutter/packages into QA-pigeon
tarrinneal 2ca3980
nits
tarrinneal 110a311
delete file
tarrinneal 20796bb
remove parser class
tarrinneal e2dc2b7
method names
tarrinneal bfe3748
non static
tarrinneal f8bf4b2
message
tarrinneal 249d3f8
selfies
tarrinneal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| ## 1.0.8 | ||
|
|
||
| * Changes method channels to pigeon. | ||
|
|
||
| ## 1.0.7 | ||
|
|
||
| * Adds pub topics to package metadata. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ons/quick_actions_ios/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
...s/quick_actions/quick_actions_ios/example/ios/RunnerTests/Mocks/MockBinaryMessenger.swift
tarrinneal marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import Flutter | ||
|
|
||
| @testable import quick_actions_ios | ||
|
|
||
| class MockBinaryMessenger: NSObject, FlutterBinaryMessenger { | ||
tarrinneal marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| let codec: FlutterMessageCodec | ||
| var result: Any? | ||
| private(set) var handlers: [String: FlutterBinaryMessageHandler] = [:] | ||
|
|
||
| override init() { | ||
| self.codec = FlutterStandardMessageCodec.sharedInstance() | ||
| super.init() | ||
| } | ||
|
|
||
| func send(onChannel channel: String, message: Data?) {} | ||
|
|
||
| func send( | ||
| onChannel channel: String, | ||
| message: Data?, | ||
| binaryReply callback: FlutterBinaryReply? = nil | ||
| ) { | ||
| if let result = result { | ||
| callback?(codec.encode([result])) | ||
| } | ||
| } | ||
|
|
||
| func setMessageHandlerOnChannel( | ||
| _ channel: String, | ||
| binaryMessageHandler handler: FlutterBinaryMessageHandler? = nil | ||
| ) -> FlutterBinaryMessengerConnection { | ||
| handlers[channel] = handler | ||
| return .init(handlers.count) | ||
| } | ||
|
|
||
| func cleanUpConnection(_ connection: FlutterBinaryMessengerConnection) {} | ||
| } | ||
14 changes: 0 additions & 14 deletions
14
...ges/quick_actions/quick_actions_ios/example/ios/RunnerTests/Mocks/MockMethodChannel.swift
This file was deleted.
Oops, something went wrong.
16 changes: 0 additions & 16 deletions
16
...uick_actions/quick_actions_ios/example/ios/RunnerTests/Mocks/MockShortcutItemParser.swift
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.