Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cupertino_icons] Update README to link to API docs #508

Merged
merged 3 commits into from
Nov 5, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 4, 2021

  1. Update 0.1.3 glyph map from broken https://raw.githubusercontent.com/flutter/cupertino_icons/master/map.png to updated https://raw.githubusercontent.com/flutter/packages/master/third_party/packages/cupertino_icons/map.png.
  2. Replace dead link https://flutter.github.io/cupertino_icons to instead link to the API docs.

Package README/pub documentation part of flutter/flutter#88754.

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@jmagman jmagman self-assigned this Nov 4, 2021
@google-cla google-cla bot added the cla: yes label Nov 4, 2021
@jmagman jmagman requested a review from stuartmorgan November 4, 2021 20:47
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! LGTM

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jmagman jmagman merged commit 2cbc815 into flutter:master Nov 5, 2021
@jmagman jmagman deleted the cupertino-readme branch November 5, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants