[image_picker_web] Listens to file input cancel event. #4453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
commented
Jul 13, 2023
stuartmorgan-g
requested changes
Jul 17, 2023
ditman
force-pushed
the
image-picker-web-cancel-event
branch
from
f8c9ba3 to
4f1047f
Compare
Member
Author
|
I've updated the README to mention the current methods (not the ones I'm removing), and marked this change as a major version to prevent any issues with package resolution (I'll send a PR updating |
11 tasks
ditman
force-pushed
the
image-picker-web-cancel-event
branch
from
4f1047f to
08eb6d1
Compare
stuartmorgan-g
approved these changes
Jul 20, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM modulo the version constraint.
ditman
force-pushed
the
image-picker-web-cancel-event
branch
from
08eb6d1 to
c40b18c
Compare
* Delegates deprecated methods to non-deprecated ones.
* Moves tests of old methods to a "Deprecated" group so they can be cleaned up easily later.
…iguration object can do.
Member
Author
|
Hey @stuartmorgan, here's the refresh to the |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 4, 2023
flutter/packages@d00c1f9...ce53da1 2023-08-04 [email protected] [image_picker_web] Listens to file input cancel event. (flutter/packages#4453) 2023-08-04 [email protected] [in_app_purchase] Updates handling of subscription price changes in README. (flutter/packages#4643) 2023-08-03 [email protected] [pigeon] Consolidate main Dart unit tests (flutter/packages#4641) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR listens to the
cancelevent from theinput type=fileused by the web implementation of the image_picker plugin, so apps don't end up endlessly awaiting for a file that will never come in modern browsers (Chrome 113, Safari 16.4, or newer). Same API as #3683.Additionally, this PR:
PickedFile. (Deprecated years ago, and unused since [image_picker] Update to 1.0 #4285) (Breaking change)XFilewhich is the current return type of the package.image_picker_platform_interfaceto^2.9.0.Issues
Testing
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.