Skip to content

[metrics_center] Remove Equatable dependency #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Jul 12, 2023
Merged

[metrics_center] Remove Equatable dependency #4444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/metrics_center/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.0.11

* Removes the dependency on `package:equatable`.

## 1.0.10

* Adds retry logic when removing a `GcsLock` file lock in case of failure.
Expand Down
10 changes: 2 additions & 8 deletions packages/metrics_center/lib/src/common.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@ import 'dart:collection';
import 'dart:convert';

import 'package:crypto/crypto.dart';
import 'package:equatable/equatable.dart';

import 'package:googleapis_auth/googleapis_auth.dart';
import 'package:http/http.dart';

/// Common format of a metric data point.
class MetricPoint extends Equatable {
class MetricPoint {
/// Creates a new data point.
MetricPoint(
this.value,
Expand All @@ -25,6 +23,7 @@ class MetricPoint extends Equatable {
/// Test name, unit, timestamp, configs, git revision, ..., in sorted order.
UnmodifiableMapView<String, String> get tags =>
UnmodifiableMapView<String, String>(_tags);
final SplayTreeMap<String, String> _tags;

/// Unique identifier for updating existing data point.
///
Expand All @@ -39,11 +38,6 @@ class MetricPoint extends Equatable {
String toString() {
return 'MetricPoint(value=$value, tags=$_tags)';
}

final SplayTreeMap<String, String> _tags;

@override
List<Object?> get props => <Object?>[value, tags];
}

/// Interface to write [MetricPoint].
Expand Down
3 changes: 1 addition & 2 deletions packages/metrics_center/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: metrics_center
version: 1.0.10
version: 1.0.11
description:
Support multiple performance metrics sources/formats and destinations.
repository: https://github.com/flutter/packages/tree/main/packages/metrics_center
Expand All @@ -11,7 +11,6 @@ environment:
dependencies:
_discoveryapis_commons: ^1.0.0
crypto: ^3.0.1
equatable: ^2.0.3
gcloud: ^0.8.2
googleapis: ^3.0.0
googleapis_auth: ^1.1.0
Expand Down