Skip to content

Conversation

@ditman
Copy link
Member

@ditman ditman commented Jun 24, 2023

This reverts commit 8b6998f.

Attempts to mitigate: flutter/flutter#129467

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from stuartmorgan-g June 24, 2023 02:32

### Android tasks ###
- name: Linux_android android_build_all_packages master
bringup: true # New target
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might not be allowed to make bringup: true after the task has been moved out of bringup once :/ I guess the ci.yaml validation will tell!

@ditman
Copy link
Member Author

ditman commented Jun 26, 2023

This was the actual underlying problem:

@ditman ditman closed this Jun 26, 2023
@ditman ditman deleted the revert-8b6998f8e branch June 26, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant