Skip to content

Add missing ignores for textScaleFactor deprecation #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Jun 17, 2023
+10 −10
Merged

Add missing ignores for textScaleFactor deprecation #4239

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b867bb
Add missing ignores for textScaleFactor deprecation
LongCatIsLooong Jun 17, 2023
191fadd
format
LongCatIsLooong Jun 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/flutter_markdown/lib/src/builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,17 +829,17 @@ class MarkdownBuilder implements md.NodeVisitor {
if (selectable) {
return SelectableText.rich(
text!,
textScaleFactor:
styleSheet.textScaleFactor, // ignore: deprecated_member_use
// ignore: deprecated_member_use
textScaleFactor: styleSheet.textScaleFactor,
textAlign: textAlign ?? TextAlign.start,
onTap: onTapText,
key: k,
);
} else {
return RichText(
text: text!,
textScaleFactor:
styleSheet.textScaleFactor!, // ignore: deprecated_member_use
// ignore: deprecated_member_use
textScaleFactor: styleSheet.textScaleFactor!,
textAlign: textAlign ?? TextAlign.start,
key: k,
);
Expand Down
15 changes: 7 additions & 8 deletions packages/flutter_markdown/test/text_scale_factor_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ void defineTests() {
await tester.pumpWidget(
boilerplate(
const MediaQuery(
data: MediaQueryData(
textScaleFactor: 2.0), // ignore: deprecated_member_use
// ignore: deprecated_member_use
data: MediaQueryData(textScaleFactor: 2.0),
child: MarkdownBody(
data: data,
),
Expand All @@ -57,8 +57,8 @@ void defineTests() {
await tester.pumpWidget(
boilerplate(
const MediaQuery(
data: MediaQueryData(
textScaleFactor: 2.0), // ignore: deprecated_member_use
// ignore: deprecated_member_use
data: MediaQueryData(textScaleFactor: 2.0),
child: MarkdownBody(
data: data,
selectable: true,
Expand All @@ -67,10 +67,9 @@ void defineTests() {
),
);

final SelectableText selectableText =
tester.widget(find.byType(SelectableText));
expect(selectableText.textScaleFactor,
2.0); // ignore: deprecated_member_use
final SelectableText selectableText = tester.widget(find.byType(SelectableText));
// ignore: deprecated_member_use
expect(selectableText.textScaleFactor, 2.0);
},
);
});
Expand Down