[webview_flutter] Explicitly disable ATS in example apps #4166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our integration tests connect to a local server via HTTP; currently we are relying on ATS default behavior of allowing that for local network requests, but we should instead explicitly allow the example apps to load HTTP URLs in the webview via `NSAppTransportSecurity`.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
test-exempt: configuration change |
stuartmorgan-g
added
the
override: no changelog needed
Collaborator
Author
|
No changelog: dev-only change. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 9, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 9, 2023
flutter/packages@e13b8c4...afe2f05 2023-06-08 [email protected] [image_picker] Add desktop support - platform interface (flutter/packages#4161) 2023-06-08 [email protected] [go_router] Update link to example for query and path parameters (flutter/packages#3994) 2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.0 to 1.8.21 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3839) 2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter/packages#3768) 2023-06-08 [email protected] [webview_flutter] Explicitly disable ATS in example apps (flutter/packages#4166) 2023-06-08 [email protected] Roll Flutter from 8a5c22e to 6e254a3 (12 revisions) (flutter/packages#4165) 2023-06-08 [email protected] Fix stale ignore: prefer_const_constructors from flutter/packages (flutter/packages#4154) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our integration tests connect to a local server via HTTP; currently we are relying on ATS default behavior of allowing that for local network requests, but we should instead explicitly allow the example apps to load HTTP URLs in the webview via
NSAppTransportSecurity.This allows integration tests to run on iOS 17, which appears to have tightened the ATS defaults.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).