-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[camerax] Publish plugin #3896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[camerax] Publish plugin #3896
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
dec3d69
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 0e0333b
Merge remote-tracking branch 'upstream/main'
camsim99 bd7ac99
Merge remote-tracking branch 'upstream/main'
camsim99 4894177
Publish plugin
camsim99 8eeb6b0
Undo strange changes
camsim99 d42261f
Undo unecessary change
camsim99 94f26e9
Try ignoring plugin
camsim99 759e327
Merge remote-tracking branch 'upstream/main' into camx_publish
camsim99 35adb44
Take Stuart's suggestion
camsim99 2a94a61
Address review
camsim99 1af1eef
Merge remote-tracking branch 'upstream/main' into camx_publish
camsim99 bd5d831
Bump Dart lower bound
camsim99 d27e13b
Use Stuart's format
camsim99 4803489
Merge remote-tracking branch 'upstream/main' into camx_publish
camsim99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,8 @@ name: camera_android_camerax | |
| description: Android implementation of the camera plugin using the CameraX library. | ||
| repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax | ||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22 | ||
| publish_to: 'none' | ||
|
|
||
| version: 0.5.0 | ||
|
|
||
| environment: | ||
| sdk: ">=2.18.0 <4.0.0" | ||
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest removing every entry except for this line (since from a client perspective there's nothing that these incremental changes are relative to, this being the first release), and then expanding this a bit to have a summary of what is implemented and a pointer to the readme for details.