Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera_avfoundation]Allow to get all available cameras on iOS, such as dual camera, triple camera. #3721

Closed
wants to merge 3 commits into from

Conversation

Kylin3216
Copy link

@Kylin3216 Kylin3216 commented Apr 16, 2023

Allow to get all available cameras on iOS, such as dual camera, triple camera.

issue like #104439,#80865, fixed by flutter/plugins#5636.

but on my iphone 13, ios 16.3.1 , it still can't get all cameras, inspired by flutter/plugins#5636., I add more device type for discovery.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Kylin3216 Kylin3216 requested a review from hellohuanlin as a code owner April 16, 2023 13:17
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Kylin3216 Kylin3216 changed the title Allow to get all available cameras, such as dual camera, triple camera. Allow to get all available cameras on iOS, such as dual camera, triple camera. Apr 16, 2023
@Kylin3216 Kylin3216 changed the title Allow to get all available cameras on iOS, such as dual camera, triple camera. [camera_avfoundation]Allow to get all available cameras on iOS, such as dual camera, triple camera. Apr 16, 2023
@Kylin3216
Copy link
Author

dual camera,triple camera are logic camera,i think this can not pass the tests

@Kylin3216 Kylin3216 closed this Apr 17, 2023
@Kylin3216
Copy link
Author

dual camera,triple camera are logic camera,i think this can not pass the tests

@hellohuanlin
Copy link
Contributor

it should be testable even if they are logic camera. any specific error you are seeing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants