Skip to content

[go_router] Remove navigator keys parameters #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Apr 5, 2023
Merged

[go_router] Remove navigator keys parameters #3614

auto-submit merged 3 commits into from
Apr 5, 2023

Conversation

@GP4cK
Copy link
Contributor

@GP4cK GP4cK commented Apr 1, 2023

This PR reverts the changes made in #3471.
The parameters which were introduced could not be used because GlobalKey<NavigatorState>() is not a const.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@GP4cK GP4cK requested a review from chunhtai as a code owner April 1, 2023 06:18
@chunhtai
Copy link
Contributor

chunhtai commented Apr 3, 2023

We should publish a new version

@GP4cK GP4cK force-pushed the add-navigator-key-getters branch from fee6191 to 025d213 Compare April 4, 2023 03:57
chunhtai
chunhtai approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit auto-submit bot merged commit 6e40887 into flutter:main Apr 5, 2023
@GP4cK GP4cK deleted the add-navigator-key-getters branch April 6, 2023 00:07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 6, 2023
@engine-flutter-autoroll
6e40887 [go_router] Remove navigator keys parameters (flutter/package…
51ae103 
…s#3614)
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@GP4cK @nploi
[go_router] Remove navigator keys parameters (flutter#3614)
8084a2e 
[go_router] Remove navigator keys parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnpryan johnpryan johnpryan approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: go_router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GP4cK @chunhtai @johnpryan