Skip to content

[camerax] Fix CameraInfo cast causing failure in integration test #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Mar 27, 2023
Merged

[camerax] Fix CameraInfo cast causing failure in integration test #3558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0708f38
Fix cast
camsim99 Mar 27, 2023
d0507cb
Merge branch 'main' into camx_cast
camsim99 Mar 27, 2023
9c64300
Add changelog entry
camsim99 Mar 27, 2023
bee037b
Merge branch 'camx_cast' of github.com:camsim99/packages into camx_cast
camsim99 Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/camera/camera_android_camerax/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@
* Bump CameraX version to 1.3.0-alpha04.
* Fixes instance manager hot restart behavior and fixes Java casting issue.
* Implements image capture.
* Fixes cast of CameraInfo to fix integration test failure.
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/lib/src/camera_selector.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ class CameraSelectorHostApiImpl extends CameraSelectorHostApi {
}
return filteredCameraInfoIds
.map<CameraInfo>((int? id) =>
instanceManager.getInstanceWithWeakReference(id!)! as CameraInfo)
instanceManager.getInstanceWithWeakReference<CameraInfo>(id!)!)
.toList();
}
}
Expand Down