-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[camerax] Implement video capture for CameraX android camera re-write #3467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f876e73
remaking video capture pr to fix CLA issue
ca2a353
accepting documentation change to createTempFile
22eea7a
making video recording tests into a group, and random typo
77dfba1
Merge branch 'main' into video_capture
gmackall daf385b
Merge branch 'flutter:main' into video_capture
gmackall 167f9c2
documentation changes from review comments
23ec03e
changing test name
034a508
Merge branch 'flutter:main' into video_capture
gmackall d5affdd
changing a use of RuntimeException to a FlutterError
9797067
format
c76d1a4
adding tests for error cases in stopVideoRecording
3141b02
formatting
92a51b8
Making explicit that we do nothing on pressing record twice, and addi…
5e776a5
formatting new tests
0ba0dfc
review comments around documentation and an assert
89d7936
removing use of the word 'we' per the style guide
9eecbed
removing second 'assert' that was copied over from first instance of …
f8eee31
Merge branch 'main' into video_capture
gmackall fb4770b
Merge branch 'main' into video_capture
gmackall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.