Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual flutter roll and analyzer fix #3174

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Manual flutter roll and analyzer fix #3174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9356c2c
fix for new analyzer rules
tarrinneal Feb 6, 2023
489947a
manual roll
tarrinneal Feb 6, 2023
59b1024
remove second ignore
tarrinneal Feb 6, 2023
ad712a8
nits
tarrinneal Feb 6, 2023
e1cf306
update readme
tarrinneal Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/flutter_master.version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ca0596e41da32b51891a026756a5eae123861092
40b5e4cb5e7720cc5ab5edb59cb96eab5530d829
1 change: 0 additions & 1 deletion packages/flutter_adaptive_scaffold/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ displayed and the entrance animation and exit animation.
inAnimation: AdaptiveScaffold.leftOutIn,
builder: (_) => AdaptiveScaffold.standardNavigationRail(
extended: true,
// ···
leading: Row(
mainAxisAlignment: MainAxisAlignment.spaceAround,
children: const <Widget>[
Expand Down
9 changes: 3 additions & 6 deletions packages/flutter_adaptive_scaffold/example/lib/adaptive_layout_demo.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(goderbauer): Remove this ignore when this package requires Flutter 3.8 or later.
// ignore_for_file: prefer_const_constructors

import 'package:flutter/material.dart';
import 'package:flutter_adaptive_scaffold/flutter_adaptive_scaffold.dart';

Expand Down Expand Up @@ -45,8 +48,6 @@ class MyHomePage extends StatelessWidget {
children: <Widget>[
const Divider(color: Colors.black),
const SizedBox(height: 10),
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
Row(
children: const <Widget>[
SizedBox(
Expand Down Expand Up @@ -152,10 +153,6 @@ class MyHomePage extends StatelessWidget {
inAnimation: AdaptiveScaffold.leftOutIn,
builder: (_) => AdaptiveScaffold.standardNavigationRail(
extended: true,
// #enddocregion Example
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
// #docregion Example
leading: Row(
mainAxisAlignment: MainAxisAlignment.spaceAround,
children: const <Widget>[
Expand Down