Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xdg_directories] Mark as 1.0 #3091

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Conversation

stuartmorgan
Copy link
Contributor

We've been using this as the foundation for path_provider_linux for quite some time, meaning it's had a lot of real-world testing, and we've barely needed to change it. Given that, 1.0 better reflects the current state of the package.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

We've been using this as the foundation for `path_provider_linux` for
quite some time, meaning it's had a lot of real-world testing, and we've
barely needed to change it. Given that, 1.0 better reflects the current
state of the package.
@stuartmorgan
Copy link
Contributor Author

@gspencergoog Ping, any concerns with updating the version here?

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 7, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 7, 2023

auto label is removed for flutter/packages, pr: 3091, due to - This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 10, 2023
@auto-submit auto-submit bot merged commit 6e32045 into flutter:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: xdg_directories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants