-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows redirect method to return same location #2773
Conversation
938f715
to
fdc92dd
Compare
on pub.dev for v5.1.3 it states that uri and path parameters should be in GoRouter, but they aren't https://pub.dev/documentation/go_router/5.1.3/go_router/GoRouter-class.html |
@ahmednfwela oops I think I messed up the change log, I will fix it. You can now use GoRouterState.of(context) to access the uri and path parameters |
@chunhtai but what if I don't have the context (e.g. in controller-based architecture) ? how can I access the path parameters ? |
use a |
what I mean is accessing the parameters outside the flutter widget tree, where I am relying entirely on the |
@ahmednfwela That is a use case i have not thought about, can you open an issue so that we can discuss in there? |
@chunhtai I have opened flutter/flutter#114642 |
* Allows redirect method to return same location * format and bump version
fixes flutter/flutter#106214
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.